Revert the OIDC callback to use a custom scheme for now. #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 6a0fdb9 |
Universal links are still slightly unreliable. We need to host a page at the redirect location so that if universal link detection fails we can fall back to opening the app using the scheme.
pixlwave
force-pushed
the
doug/oidc-url
branch
from
0067ca1 to
6a0fdb9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal links are still slightly unreliable for the OIDC callback. This PR is the first part of #1936 and a partial revert of #1681. Will follow this up in November once we have time to test hosting a page with a redirect as a fallback.